Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Server: Get request is not ending \r\n #302

Closed
abhinav1708 opened this issue Apr 20, 2021 · 4 comments
Closed

Proxy Server: Get request is not ending \r\n #302

abhinav1708 opened this issue Apr 20, 2021 · 4 comments

Comments

@abhinav1708
Copy link

As per HTTP 1.0 standard, request lines should end with CR LF i.e. \r\n
https://www.w3.org/Protocols/HTTP/1.0/spec.html#Request-Line
Request-Line = Method SP Request-URI SP HTTP-Version CRLF

This was being followed in handleProxyPostOrPut but for Get request line was ended with \n
handleProxyRequest function line number 385
remotePrintWriter.print(method + " " + uri + " HTTP/1.0\n");

Because of this Get request was not working on some servers in proxy mode

Created a pull request to fix this issue #301

@abhinav1708
Copy link
Author

Pull request for code fix
#301
#301

@tntim96
Copy link
Owner

tntim96 commented Apr 21, 2021

Thanks for the fix. I'll do a new release soon.

tntim96 added a commit that referenced this issue Apr 21, 2021
@abhinav1708
Copy link
Author

@abhinav1708
Copy link
Author

abhinav1708 commented Apr 21, 2021

Issue fixed via #301

sirrrich pushed a commit to sirrrich/JSCover that referenced this issue Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants