isCoalesce returns false on "return variable || defaultValue"

[tarnowsc]

The method isCoalesce of BranchHelper class could be enhanced like that:

public boolean isCoalesce(AstNode node) {
        return node.getType() == Token.OR && (node.getParent().getType() == Token.ASSIGN || node.getParent().getType() == Token.VAR
                || node.getParent().getType() == Token.RETURN);
}

[tntim96]

Sure, so with this test case added to BranchHelperTest

    @Test
    public void shouldDetectCoalesceOnReturn() {
        String script = "function f(y) {return y || {};}";
        AstRoot astRoot = parser.parse(script, null, 1);
        AstNode orNode = NodeTestHelper.findNode(astRoot, Token.OR);
        assertThat(helper.isCoalesce(orNode), is(true));
    }

[tarnowsc]

Works like a charm.