Fix NullPointerException when Logger is removed while looping (#225)

tntim96 · Mar 30, 2016 · de06770 · de06770
1 parent 89ffb42
commit de06770
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/History.md b/History.md
@@ -3,6 +3,7 @@
   * Upgrade to Rhino 1.7.7.1
   * Improve Logic To Determine Inverted Mode (https://github.com/tntim96/JSCover/issues/223)
   * Don't Switch To Inverted Mode If There's A Query String (https://github.com/tntim96/JSCover/issues/222)
+  * Fix NullPointerException when Logger is removed while looping (https://github.com/tntim96/JSCover/pull/225)
   * Internal: Upgrade HtmlUnit 2.19 to 2.20
 
 1.0.23 / 2016-01-03

diff --git a/src/main/java/jscover/util/LoggerUtils.java b/src/main/java/jscover/util/LoggerUtils.java
@@ -386,9 +386,7 @@ private void alterLoggers(Level level, File file) throws IOException {
         while (names.hasMoreElements()) {
             String loggerName = names.nextElement();
             Logger logger = LogManager.getLogManager().getLogger(loggerName);
-            if (logger == null) {
-                continue;
-            }
+            if (logger == null) continue;
             logger.setLevel(level);
             logger.addHandler(fileTxt);
             Handler[] handlers = logger.getHandlers();
@@ -404,9 +402,7 @@ private void addExceptionRecorder() {
         while (names.hasMoreElements()) {
             String loggerName = names.nextElement();
             Logger logger = LogManager.getLogManager().getLogger(loggerName);
-            if (logger == null) {
-                continue;
-            }
+            if (logger == null) continue;
             logger.addHandler(exceptionRecordingHandler);
         }
     }