fix evalue_required_docs, schema update

tnightengale · Nov 30, 2020 · 710289b · 710289b
1 parent b228969
commit 710289b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/macros/utils/required_docs/evaluate_required_docs.sql b/macros/utils/required_docs/evaluate_required_docs.sql
@@ -22,12 +22,12 @@
 
         {% for column in model_columns %}
 
-            {{ logger(column) }}
-            {{ logger(column) }}
-            {% if column | lower in model.columns.keys() %}
+            {% set column = column | lower %}
+
+            {% if column in model.columns.keys() %}
 
                 {{ logger(column ~ " is in " ~ model.columns.keys()) }}
-                {% if model.columns[column] == "" %}
+                {% if model.columns[column].description == "" %}
 
                     {% do missing_description_errors.append(" - " ~ model.name ~ "." ~ column) %}
 

diff --git a/models/example/schema.yml b/models/example/schema.yml
@@ -6,7 +6,7 @@ models:
       description: "A starter dbt model"
       columns:
           - name: id
-            description: "The primary key for this table"
+            description: ""
             tests:
                 - unique
                 - not_null
@@ -22,8 +22,3 @@ models:
             tests:
                 - unique
                 - not_null
-          - name: new
-            tests:
-              - unique
-              - not_null
-