Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial Chinese (simplified) locale #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add partial Chinese (simplified) locale #18

wants to merge 3 commits into from

Conversation

1lann
Copy link
Member

@1lann 1lann commented Mar 14, 2021

I translated some bits of it.

@Lemmmy Lemmmy added the i18n This issue or pull request is related to translations/internationalisation label Mar 14, 2021
@Lemmmy Lemmmy added this to the v2.0.0 milestone Mar 14, 2021
@Lemmmy
Copy link
Member

Lemmmy commented Mar 14, 2021

Thanks for this! ❤️ would you like it merged sooner, or do you want to finish it first?

Comment on lines +82 to +83
"dayjsLocale": "zh",
"timeagoLocale": "zh",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, I believe the timeago locale is zh-CN:
https://github.com/nmn/react-timeago/blob/master/src/language-strings/zh-CN.js

Day.js also has zh and zh-cn, which have some tiny differences (relativeTime.future), not sure which one is correct here, I'll leave that to your judgement:
https://github.com/iamkun/dayjs/blob/dev/src/locale/zh-cn.js
https://github.com/iamkun/dayjs/blob/dev/src/locale/zh.js

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok I didn't know where those locales really came from, but yeah I'll change that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference to anyone reading this, they're documented in the translating section in the README: https://github.com/tmpim/KristWeb2#contributing-translations

@1lann
Copy link
Member Author

1lann commented Mar 14, 2021

I can probably add some more to it first I'm in no rush, worst case just merge it in when KristWeb2 is released or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n This issue or pull request is related to translations/internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants