-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial Chinese (simplified) locale #18
base: master
Are you sure you want to change the base?
Conversation
Thanks for this! ❤️ would you like it merged sooner, or do you want to finish it first? |
"dayjsLocale": "zh", | ||
"timeagoLocale": "zh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm mistaken, I believe the timeago locale is zh-CN
:
https://github.com/nmn/react-timeago/blob/master/src/language-strings/zh-CN.js
Day.js also has zh
and zh-cn
, which have some tiny differences (relativeTime.future
), not sure which one is correct here, I'll leave that to your judgement:
https://github.com/iamkun/dayjs/blob/dev/src/locale/zh-cn.js
https://github.com/iamkun/dayjs/blob/dev/src/locale/zh.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok I didn't know where those locales really came from, but yeah I'll change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference to anyone reading this, they're documented in the translating section in the README: https://github.com/tmpim/KristWeb2#contributing-translations
I can probably add some more to it first I'm in no rush, worst case just merge it in when KristWeb2 is released or something. |
I translated some bits of it.