This repository has been archived by the owner on Apr 8, 2022. It is now read-only.
Do not run zxcvbn on long passwords #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would consider placing this limit as 64 chars instead, as you can get pretty insecure passwords by combining 3 dictionary words that are still longer than 24 chars. |
|
According to this issue and a few related issues, the issues only start to appear in the order of 256+ chars, so this limit could be placed around 128 safely, while still ensuring the security of passwords is properly checked. |
|
Changed to 128 |
Lignum
suggested changes
May 6, 2018
src/js/modal/login-wallet/modal.js
Outdated
| } else { | ||
| let strength = zxcvbn(password); | ||
| let score = strength.score; | ||
| } |
There was a problem hiding this comment.
This can't be right. let variables do not exist outside of their scope like vars do. I think you mean:
const score = password.length >= 128 ? 5 : zxcvbn(password).score;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I know from personal experience, long passwords result in the web-page hanging due to strength estimation.