Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Accidentally, this is the biggest visual upgrade that this project has ever had
Context
This started off as an attempt to remove "duplicate" sprite images - I was a little suspicious when I saw that there were 1,000+! (out of ~5000 total images)
Upon further inspection, I noticed that there could possibly even be more duplictes, as many images look similar but are positioned slightly differently in the original PNG (due to padding).
I created a command to "autocrop" the images first to deal with this, and now the sprites look a lot more bright and detailed! 🎉
The benefit of cropping the PNGs first in the conversion pipeline seems to be twofold:
Previously, for 2 images that are almost exactly the same, but positioned differently on the backend, could have been different text characters after conversion
img2xterm
seems to like converting the images without all the white/transparent background, it appears to have been adjusting the contrast accordinglyChanges
imagemagick
in docker imageconvert
command to "trim" the background automaticallyExamples
pokesay
. These examples roughly represent the impact of the visual upgrade that users will experience