Adapted readme for docker image #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@th4s The docker package is outdated. Let's wait for @yuroitaki to have a look at this |
Yep this error is expected when one runs the docker image against the latest prover code because we have not released the latest version of notary-server docker image, as its versioning is now tied with that of tlsn core lib (more discussion here). There is this P/S reminder in the README that reminds people to use prover of the same tag with that of notary-server docker image, so hopefully that is fine. For now we should update the README to use a functioning docker image url still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the README with the correct link to pull the docker image for the notary server. Closes #381