Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utils): Inplace operations and std traits #41

Merged
merged 4 commits into from
Oct 8, 2024
Merged

feat(utils): Inplace operations and std traits #41

merged 4 commits into from
Oct 8, 2024

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Oct 6, 2024

This PR adds inplace implementations for a couple of the set operations, and implements std traits for them.

@sinui0 sinui0 requested review from themighty1 and th4s October 6, 2024 18:58
th4s
th4s reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I have some questions

utils/src/range/difference.rs Show resolved Hide resolved
utils/src/range/mod.rs Outdated Show resolved Hide resolved
@sinui0 sinui0 requested a review from th4s October 8, 2024 13:39
@sinui0 sinui0 merged commit 6f62968 into dev Oct 8, 2024
2 checks passed
@sinui0 sinui0 deleted the feat/range-set-ops branch October 8, 2024 17:07
@themighty1
Copy link
Member

ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th4s th4s th4s approved these changes

@themighty1 themighty1 Awaiting requested review from themighty1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinui0 @themighty1 @th4s