feat(utils): extract_if backport #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
approved these changes
Oct 1, 2024
| where | ||
| F: FnMut(&mut T) -> bool, | ||
| { | ||
| pub(super) vec: &'a mut Vec<T>, |
There was a problem hiding this comment.
I think we do not need pub(super) here, because we create FilterDrainIter in the same module.
There was a problem hiding this comment.
I just copy pasted exactly from the std source, it should be fine
There was a problem hiding this comment.
In the end it doesn't matter, but you use a trait in the same module to instantiate it, while the standard library does the instantiation in the super module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our existing
FilterDrain, backporting the std implementation ofextract_ifuntil it reaches stabilization.Source code is directly copied (minus renaming) including the tests.