Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): additional set operations #39

Merged
merged 6 commits into from
Sep 5, 2024
Merged

feat(utils): additional set operations #39

merged 6 commits into from
Sep 5, 2024

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Sep 2, 2024

Closes #8

This PR adds the set intersection operation and additional subset implementations. I've also removed the superset operation which is redundant with subset.

Exhaustively testing these operations is difficult so I've added more fuzz targets, and included a proof for set-set intersection.

Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

I think there is an issue with the subset implementation.

EDIT: I forgot about the invariants of RangeSet.

utils/src/range/subset.rs Show resolved Hide resolved
utils/src/range/subset.rs Show resolved Hide resolved
@sinui0 sinui0 merged commit e7b2db6 into dev Sep 5, 2024
2 checks passed
@sinui0 sinui0 deleted the feat/set-traits branch September 5, 2024 02:29
@themighty1
Copy link
Member

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add set intersection
3 participants