Add plugin context to get browser storage #101
+198
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heeckhau
requested changes
Sep 24, 2024
0xtsukino
requested changes
Sep 24, 2024
0xtsukino
reviewed
Sep 24, 2024
Codetrauma
changed the title
|
@0xtsukino @heeckhau works now in plugins like we do with headers and cookies using |
|
@Codetrauma can you rebase on alpha.7 before I review? |
heeckhau
force-pushed
the
hostfunctions
branch
from
4e4ee65
to
33cf958
Compare
heeckhau
requested changes
Oct 10, 2024
heeckhau
reviewed
Oct 15, 2024
heeckhau
reviewed
Oct 15, 2024
Co-authored-by: Hendrik Eeckhaut <[email protected]>
heeckhau
approved these changes
Oct 15, 2024
0xtsukino
reviewed
Oct 29, 2024
0xtsukino
reviewed
Nov 26, 2024
| if (config?.sessionStorage) { | ||
| const sessionStorage: { [hostname: string]: { [key: string]: string } } = | ||
| {}; | ||
| (async () => { |
There was a problem hiding this comment.
shouldn't this be await?
| if (config?.localStorage) { | ||
| const localStorage: { [hostname: string]: { [key: string]: string } } = {}; | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
same here - should this be await?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can get items from local and session storage by their key.
@0xtsukino if you can look this over. Getting an error "Cannot convert undefined to BigInt" when trying to test this in a plugin. I do receive the values of local or session storage, but unsure what the error specifically is coming from.