-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from `` code blocks to 4 spaces #758
Conversation
It was a one line script with sed, so not a lot of work. This was kinda the introduction to discuss the change. I would have to change https://github.com/tldr-pages/tldr-lint/blob/master/lib/tldr-parser.js#L736 and https://github.com/tldr-pages/tldr-lint/blob/master/lib/tldr-parser.js#L758 to allow for 8 spaces, etc. When using a client, they are formatted in an easy way to copy paste, but if you open the markdown files themselves it is a bit tougher. Of course most people should be using a client, but I thought it looks nicer with 8 spaces (and matches the output of most tools that parse it). Would people be vehemently against changing the tldr-linter to look for 8 spaces instead of backticks? I feel like it would actually remove some of the client-side work but maybe i'm totally off there... |
nevermind, saw a bunch of implementations, they rely on '`' |
I would still like this to be discussed. See #686 (comment) |
Poor man actually checked out the generated parser file. |
Well, never worked with any lexer or parser, so didnt even look at the .yy or .l files. Still don't know if these are the right places to change things, but: https://github.com/tldr-pages/tldr-lint/blob/master/tldr.yy#L53-L55 and https://github.com/tldr-pages/tldr-lint/blob/master/tldr.l#L138-L141 probably relevant. Somewhat related, maybe generated files shouldn't be checked into the source repo? But I don't see how the generated files are made. Maybe a makefile or just that jison thing? |
I had that problem as well, but I needed the generated files to be present upon Anyway, we'll continue the conversation |
This makes it a lot easier to copy paste with the mouse in the commandline.
I am testing now with a few implementations to make sure it works fine.