-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-rename-tag: add page #6092
git-rename-tag: add page #6092
Conversation
If no commits/changes are made can this be rebased since it is only 1 commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Why do you want it to be rebased? As far as I know it doesn't make any difference if there is only one commit.
Yes but this is acceptable to rebase |
It's perfectly fine for it to be rebased; however, since it's not necessary and we normally squash I'd prefer to squash. The added benefit (which is my primary motive) is that squashing causes the PR number to be in the commit message, which is very helpful for navigating. Rebasing causes the commit to go directly to the @CleanMachine1 if you still want to, we can go ahead and rebase this PR but I don't want to make it a habit :) |
Only because this is one commit. I'll leave the PR in the title |
No problem — it doesn't matter that much. |
common/
,linux/
, etc.)For #5137
See #5950 for what I based this on