Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-rename-tag: add page #6092

Merged
merged 1 commit into from
Jun 5, 2021
Merged

git-rename-tag: add page #6092

merged 1 commit into from
Jun 5, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5137

See #5950 for what I based this on

@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page. label Jun 4, 2021
@CleanMachine1
Copy link
Member Author

If no commits/changes are made can this be rebased since it is only 1 commit?

Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why do you want it to be rebased? As far as I know it doesn't make any difference if there is only one commit.

@CleanMachine1
Copy link
Member Author

Yes but this is acceptable to rebase

@bl-ue
Copy link
Contributor

bl-ue commented Jun 4, 2021

It's perfectly fine for it to be rebased; however, since it's not necessary and we normally squash I'd prefer to squash. The added benefit (which is my primary motive) is that squashing causes the PR number to be in the commit message, which is very helpful for navigating. Rebasing causes the commit to go directly to the main branch unmodified (except that the the merger is attributed as "committer").

@CleanMachine1 if you still want to, we can go ahead and rebase this PR but I don't want to make it a habit :)

@CleanMachine1
Copy link
Member Author

Only because this is one commit.

I'll leave the PR in the title

@bl-ue
Copy link
Contributor

bl-ue commented Jun 4, 2021

No problem — it doesn't matter that much.

@CleanMachine1 CleanMachine1 changed the title git-rename-tag: add page git-rename-tag: add page #6092 Jun 5, 2021
@CleanMachine1 CleanMachine1 mentioned this pull request Jun 5, 2021
73 tasks
@CleanMachine1 CleanMachine1 merged commit 497cc05 into main Jun 5, 2021
@CleanMachine1 CleanMachine1 deleted the git-rename-tag branch June 5, 2021 17:09
@bl-ue bl-ue changed the title git-rename-tag: add page #6092 git-rename-tag: add page Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants