Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-cp: add page #5947

Merged
merged 13 commits into from
May 12, 2021
Merged

git-cp: add page #5947

merged 13 commits into from
May 12, 2021

Conversation

CleanMachine1
Copy link
Member

@CleanMachine1 CleanMachine1 commented May 12, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5137

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-cp.md:
Error: Parse error on line 5:
...b.com/tj/git-extras>- Copy an existing
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages/common/git-cp.md:5: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-cp.md:
Error: Parse error on line 5:
...b.com/tj/git-extras>- Copy an existing
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages/common/git-cp.md:5: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-cp.md:
Error: Parse error on line 5:
...b.com/tj/git-extras>- Copy an existing
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages/common/git-cp.md:5: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@patricedenis patricedenis added the new command Issues requesting creation of a new page. label May 12, 2021
@patricedenis patricedenis linked an issue May 12, 2021 that may be closed by this pull request
pages/common/git-cp.md Outdated Show resolved Hide resolved
Co-authored-by: Patrice Denis <[email protected]>
@patricedenis
Copy link
Collaborator

Thank a lot @CleanMachine1 for your contribution

I linked to the #3953 issue just before realizing that it's not inside. I installed git-extras from a Ubuntu distro and didn't find the command either. Where can I find it?

@CleanMachine1
Copy link
Member Author

you have to run, sudo git-extras update

I had the same issue

@patricedenis patricedenis linked an issue May 12, 2021 that may be closed by this pull request
73 tasks
@CleanMachine1
Copy link
Member Author

@patricedenis
Copy link
Collaborator

you have to run, sudo git-extras update

I had the same issue

That's right. Thanks

Note that it's strange because with this update command, git-cp is not list in the installed commands of the package.
This list of commands can be shown with the apt-file list git-extras | grep /bin command line.
May be the new commands needs to be updated as well in the deb package...

@bl-ue bl-ue removed a link to an issue May 12, 2021
73 tasks
@bl-ue bl-ue mentioned this pull request May 12, 2021
73 tasks
@CleanMachine1
Copy link
Member Author

hhh, sorry Patrice, pressed your name as well.

@patricedenis
Copy link
Collaborator

hhh, sorry Patrice, pressed your name as well.

I could have done it either

^^

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to clarify that commands can take file paths, rather than just file names. I'd prefer to use file when, for whatever reason, a command can only take a file name, without any directories.

pages/common/git-cp.md Show resolved Hide resolved
pages/common/git-cp.md Outdated Show resolved Hide resolved
pages/common/git-cp.md Outdated Show resolved Hide resolved
pages/common/git-cp.md Outdated Show resolved Hide resolved
@CleanMachine1
Copy link
Member Author

@navarroaxel could you review?

@navarroaxel navarroaxel merged commit fb60f3d into tldr-pages:main May 12, 2021
@CleanMachine1
Copy link
Member Author

was just about to ask to push, thanks

@CleanMachine1 CleanMachine1 deleted the git-cp.md branch May 12, 2021 22:52
@bl-ue
Copy link
Contributor

bl-ue commented May 12, 2021

4 approvals! I love all of the collaborators we're getting! Y'all'll be really useful during Hacktoberfast 😬 ❤️

@CleanMachine1
Copy link
Member Author

Soon i'll be one!

@CleanMachine1
Copy link
Member Author

CleanMachine1 commented May 12, 2021

It is really cool to run the, tldr --update command and then tldr git-cp and see my work and everyone else's contributions.

I find it cool that probably 10k or probably more can use our work

Do we have a demographic on how many users there are?

@bl-ue
Copy link
Contributor

bl-ue commented May 13, 2021

It is really cool to run the, tldr --update command and then tldr git-cp and see my work everyone else's contributions.

I know, it's really fun!

I find it cool that probably 10k or probably more can use our work

10k? Why not 32.7k!!

Do we have a demographic on how many users there are?

Not that I know of, as I have been lamenting since my day 1. @qpwo recently opened an issue asking about anonymous analytics (personally I'd love that❗), and there's been discussions in the past (search the issues for Mixpanel) but not much other than that that I know of...

https://star-history.t9t.io/#tldr-pages/tldr shows the star trend, at least.

@CleanMachine1
Copy link
Member Author

Why not 32k?

Because I feel most just star things in recommended, just like I did however I looked into this project since it was my interest

@bl-ue
Copy link
Contributor

bl-ue commented May 13, 2021

Yeah, you're probably right.

however I looked into this project since it was my interest

Good thing you did! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants