Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-whatchanged: add page #5935

Merged
merged 15 commits into from
May 11, 2021
Merged

git-whatchanged: add page #5935

merged 15 commits into from
May 11, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Final change for today, however I will still be replying.

I plan to do a few of these git ones since I need to learn as well and this seems like a good opportunity since I will be writing guides for other people (no pressure 😄 )

@bl-ue bl-ue added the new command Issues requesting creation of a new page. label May 10, 2021
@bl-ue bl-ue changed the title git-whatchanged: added page git whatchanged: add page May 10, 2021
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-whatchanged.md:4: TLDR003 Descriptions should start with a capital letter
pages/common/git-whatchanged.md:5: TLDR016 Label for information link should be spelled exactly `More information: `

Please fix the error(s) and push again.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice page, @CleanMachine1! I left a few comments.

pages/common/git-whatchanged.md Outdated Show resolved Hide resolved
pages/common/git-whatchanged.md Outdated Show resolved Hide resolved
pages/common/git-whatchanged.md Outdated Show resolved Hide resolved
pages/common/git-whatchanged.md Outdated Show resolved Hide resolved
@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

Also @CleanMachine1 the command name is actually whatchanged, not what-changed. Will you please change it?

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-whatchanged.md:5: TLDR016 Label for information link should be spelled exactly `More information: `

Please fix the error(s) and push again.

@CleanMachine1
Copy link
Member Author

wow thats a huge bug, I need to test more! sorry about that

pages/common/git-whatchanged.md Show resolved Hide resolved
pages/common/git-whatchanged.md Outdated Show resolved Hide resolved
pages/common/git-whatchanged.md Outdated Show resolved Hide resolved
pages/common/git-whatchanged.md Show resolved Hide resolved
@navarroaxel navarroaxel changed the title git whatchanged: add page git-whatchanged: add page May 11, 2021
@CleanMachine1
Copy link
Member Author

dce77d1

Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @CleanMachine1

@bl-ue bl-ue merged commit e557714 into tldr-pages:main May 11, 2021
@CleanMachine1 CleanMachine1 deleted the git-whatchanged branch May 11, 2021 12:00
@CleanMachine1
Copy link
Member Author

🥳 my first merged PR, already pulled on my tldr install and see it, my contributions are on a project with 32k stars!

@Waples
Copy link
Member

Waples commented May 11, 2021

Isn't this just an alias for git log {{path/to/file}} ? @bl-ue @marchersimon I get the same output with both git log and git whatchanged. So does it need it's own page?

@bl-ue
Copy link
Contributor

bl-ue commented May 11, 2021

They're quite similar, but not exactly the same.

$ git log -1
commit e5577147713eb23a64a19aa8e38ce1c1410e4fe5 (HEAD -> main, upstream/master, upstream/main, origin/main, origin/HEAD)
Author: CleanMachine1 <[email protected]>
Date:   Tue May 11 13:00:14 2021 +0100

    git-whatchanged: add page (#5935)

$ git whatchanged -1
commit e5577147713eb23a64a19aa8e38ce1c1410e4fe5 (HEAD -> main, upstream/master, upstream/main, origin/main, origin/HEAD)
Author: CleanMachine1 <[email protected]>
Date:   Tue May 11 13:00:14 2021 +0100

    git-whatchanged: add page (#5935)

:000000 100644 00000000 6a6ae929 A      pages/common/git-whatchanged.md

$ 

@CleanMachine1
Copy link
Member Author

CleanMachine1 commented May 11, 2021

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants