Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdctl: add page #5006

Merged
merged 5 commits into from
Dec 11, 2020
Merged

etcdctl: add page #5006

merged 5 commits into from
Dec 11, 2020

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Dec 4, 2020

Adds page for etcdctl, the CLI for etcd. Page for etcd coming soon!

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

tldr-bot commented Dec 4, 2020

The build for this PR failed with the following error(s):

pages/common/etcdctl.md:4: TLDR003 Descriptions should start with a capital letter
pages/common/etcdctl.md:5: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@bl-ue
Copy link
Contributor Author

bl-ue commented Dec 4, 2020

I wasn't sure if it would notice those 😄

@sahilister sahilister added the new command Issues requesting creation of a new page. label Dec 5, 2020
navarroaxel
navarroaxel reviewed Dec 8, 2020
View reviewed changes
pages/common/etcdctl.md Outdated Show resolved Hide resolved
navarroaxel
navarroaxel reviewed Dec 8, 2020
View reviewed changes
pages/common/etcdctl.md Outdated Show resolved Hide resolved
pages/common/etcdctl.md Outdated Show resolved Hide resolved
pages/common/etcdctl.md Outdated Show resolved Hide resolved
pages/common/etcdctl.md Outdated Show resolved Hide resolved
pages/common/etcdctl.md Outdated Show resolved Hide resolved
pages/common/etcdctl.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel changed the title etcdctl: add new page etcdctl: add page Dec 8, 2020
@bl-ue @navarroaxel
Apply suggestions from code review
bd1fa93 
Thank you again @navarroaxel.

Co-authored-by: Axel Navarro <[email protected]>
sbrl
sbrl reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

pages/common/etcdctl.md Outdated Show resolved Hide resolved
pages/common/etcdctl.md Outdated Show resolved Hide resolved
bl-ue and others added 2 commits December 11, 2020 16:12
@bl-ue @sbrl
Apply suggestions from code review
8a096d8 
Thank you @sbrl!

Co-authored-by: Starbeamrainbowlabs <[email protected]>
@bl-ue @sbrl
Apply suggestions from code review
c0d684b 
Co-authored-by: Starbeamrainbowlabs <[email protected]>
@bl-ue bl-ue requested a review from sbrl December 11, 2020 21:12
sbrl
sbrl approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bl-ue!

@sbrl sbrl merged commit 244a7b1 into tldr-pages:master Dec 11, 2020
@bl-ue bl-ue deleted the add-etcdctl branch December 11, 2020 21:30
@sbrl sbrl mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bl-ue @tldr-bot @navarroaxel @sbrl @sahilister