Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulumi-new: add page #14833

Merged
merged 6 commits into from
Nov 21, 2024
Merged

pulumi-new: add page #14833

merged 6 commits into from
Nov 21, 2024

Conversation

Denis-Kuso
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Nov 14, 2024
@tldr-bot

This comment was marked as resolved.

Sign in to view
gutjuri
gutjuri approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have one suggestion.

pages/common/pulumi-new.md Outdated Show resolved Hide resolved
kbdharun
kbdharun reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to tldr and thanks for your contribution. I have some minor suggestions for this page after which the PR is GTG.

Note. I closed and reopened the PR to retrigger the frozen CLA check.

pages/common/pulumi-new.md Outdated Show resolved Hide resolved
pages/common/pulumi-new.md Outdated Show resolved Hide resolved
@kbdharun kbdharun closed this Nov 18, 2024
@kbdharun kbdharun reopened this Nov 18, 2024
@nelsonfigueroa nelsonfigueroa mentioned this pull request Nov 14, 2024
Open
28 tasks
spageektti
spageektti approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

pages/common/pulumi-new.md Outdated Show resolved Hide resolved
Denis-Kuso and others added 3 commits November 20, 2024 14:35
@Denis-Kuso @kbdharun
Update pages/common/pulumi-new.md
1a1aac9 
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@Denis-Kuso @spageektti
Update pages/common/pulumi-new.md
be4c7df 
Co-authored-by: Wiktor Perskawiec <[email protected]>
@spageektti @kbdharun
Update pages/common/pulumi-new.md
6405163 
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@spageektti spageektti merged commit 9fc92f1 into tldr-pages:main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun left review comments

@spageektti spageektti spageektti approved these changes

@gutjuri gutjuri gutjuri approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Denis-Kuso @tldr-bot @gutjuri @kbdharun @spageektti