Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature support: provide translation archives #10555

Conversation

adamazing
Copy link
Contributor

@adamazing adamazing commented Jul 28, 2023

Updates build & deploy scripts to include steps which zip individual language directories.

Simple approach that adds another step to the build process that would zip up all lang directories on push.

Discussion at: https://matrix.to/#/!zXiOpjSkFTvtMpsenJ:gitter.im/$-lJoY5o2uP9LyeYJ7wi2qS9yH1ItvZP1aJLodTzhm9w?via=matrix.org

Would close: #10545

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the tooling Helper tools, scripts and automated processes. label Jul 28, 2023
@adamazing adamazing force-pushed the feature-support-download-of-individual-languages-by-clients branch from ab1fb2f to 570e11f Compare July 28, 2023 03:34
@adamazing adamazing marked this pull request as draft July 28, 2023 03:43
@adamazing adamazing force-pushed the feature-support-download-of-individual-languages-by-clients branch from 570e11f to 2a058fc Compare July 28, 2023 04:05
@kbdharun kbdharun self-requested a review July 28, 2023 04:05
@adamazing adamazing marked this pull request as ready for review July 28, 2023 04:08
@adamazing adamazing force-pushed the feature-support-download-of-individual-languages-by-clients branch 2 times, most recently from 540c937 to 321eab0 Compare July 28, 2023 04:09
@kbdharun kbdharun added the architecture Organization of the pages per language, platform, etc. label Jul 28, 2023
@adamazing adamazing force-pushed the feature-support-download-of-individual-languages-by-clients branch from 321eab0 to d39afc8 Compare July 28, 2023 04:09
@kbdharun kbdharun requested a review from owenvoke July 28, 2023 04:10
Copy link
Member

@blueskyson blueskyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. I wonder if we can only build changed translation pages in deployment. But building every translation seems inevitable.

scripts/build.sh Outdated Show resolved Hide resolved
scripts/build.sh Outdated Show resolved Hide resolved
@blueskyson blueskyson changed the title Feature Support Download Of Individual Languages By Clients feature support: provide translation archives Aug 13, 2023
@adamazing
Copy link
Contributor Author

Thanks for your contributions. I wonder if we can only build changed translation pages in deployment. But building every translation seems inevitable.

Thanks for your review @blueskyson! 🙇 I started work on a way to build archives only for changed language sub-directories but had to pause to deal with Life™️ over the past couple of weeks.

It's up to y'all if you want to merge this now or wait for the next iteration. I'll hopefully get back to this one evening this coming week.

@kbdharun kbdharun added the review needed Prioritized PRs marked for reviews from maintainers. label Aug 15, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I will merge the PR now, let's see how it pans out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Organization of the pages per language, platform, etc. review needed Prioritized PRs marked for reviews from maintainers. tooling Helper tools, scripts and automated processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support downloading & caching of a subset of languages by clients
5 participants