Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #341 #345

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fix #341 #345

merged 1 commit into from
Apr 29, 2021

Conversation

davidhcefx
Copy link
Contributor

@davidhcefx davidhcefx commented Apr 25, 2021

Description

Fix #341, which is to remove ambiguous descriptions with clearer ones.

  • -v, --version: output the version number -> Display version
  • -h, --help: display help for command -> Show this help message

Checklist

Please review this checklist before submitting a pull request.

  • Code compiles correctly
  • Created tests, if possible
  • All tests passing (npm run test:all)
  • Extended the README / documentation, if necessary

@agnivade agnivade merged commit 040af88 into tldr-pages:master Apr 29, 2021
@vladimyr
Copy link
Collaborator

vladimyr commented Apr 29, 2021

And I was just about to ask to fix for bash completion that apparently uses -V, --version... 🙃

@agnivade
Copy link
Member

I was waiting for a review from you. Anyways, we can send another PR for that.

@vladimyr
Copy link
Collaborator

Sure thing, no worries 👍

@vladimyr vladimyr mentioned this pull request May 4, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous --help message in tldr client
4 participants