-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR][Hybrid] fold attr&allocate/realize #110
Conversation
feedback: use allocate overload |
I realize a problem when trying overloading, these two different # folded allocate
a = tir.allocate("float32", [1024], "global")
with tir.allocate("float32", [1024], "global") as a:
# pure allocate
tir.allocate(a, "float32", [1024])
with tir.allocate(a, "float32", [1024]): And now the registration mechanism will discriminate these two formats, not allowing one registered function to follow two different sets of formats, and I don't want to break this limit here. Meanwhile, they accept different arguments. Since |
@spectrometerHBH your change sounds good to me. We might want to think about the argument location of tir.allocate and tir.match_buffer. To make things consistent, we might want to move the dtype after the extents |
@tqchen I see. And it seems that |
Will review today! |
see also #95
cc @tqchen @junrushao1994 @Hzfengsy