General cleanup around library wrap #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with cudadecon now available on conda-forge, i'm going to be cleaning up this library (and dropping support for OSX). This PR refactors library discovery (using the pattern from ctyped, but without depending on it)
This PR puts all of the interface declarations into
._libwrap... and provides a nice python typing look to them. Also generally reorganizes a few things, converts tests from unittest to pytest, and drops tests on travis and appveyor (which weren't really doing anything). It's hard to test this on CI due to the dependency on a GPU.