Improve typing hints in generated code #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following runtime errors: * Correctly set default to "None" for TiffData/UUID and these typing errors: * Cast default values for constrained integer attributes (both mypy and pywright were complaining about this) * Drop use of conlist in ROI/Union in favor of Field (only mypy noticed this)
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 95.28% 95.37% +0.08%
==========================================
Files 1 1
Lines 382 389 +7
==========================================
+ Hits 364 371 +7
Misses 18 18
Continue to review full report at Codecov.
|
|
I'm not totally happy with the constrained integer casting. My solution just assumes everything with a subtype of xsd:decimal needs a cast for its default value. This hits all the right stuff for the current schema, at least. Also I'm not sure what the user experience will be trying to type-check code that writes to these attributes -- will people need |
tlambert03
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following runtime errors:
and these typing errors:
pywright were complaining about this)