Make id fields non-optional but retain auto-numbering #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id fields are no longer typed as Optional, but non-reference types can still be constructed with the new auto-numbering and integer upgrade logic. Reference types must always be constructed with a valid ID string.
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 95.20% 95.12% -0.09%
==========================================
Files 1 1
Lines 396 451 +55
==========================================
+ Hits 377 429 +52
- Misses 19 22 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id fields are no longer typed as Optional, but non-reference types can
still be constructed with the new auto-numbering and integer upgrade logic.
Reference types must always be constructed with a valid ID string.
Fixes #30