Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dirty check (#17) #17

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix: dirty check (#17) #17

merged 2 commits into from
Jan 9, 2024

Conversation

tkrop
Copy link
Owner

@tkrop tkrop commented Jan 9, 2024

This pull request fixes the dirty check in go-make which prevented synchronizing the go-make.config-version with go-make-version. It also changes the Makefile.base to download by default exactly the matching go-make repository version during the update so that the upgraded config will match the installed go-make-version unless the tagof a different version or latest is supplied explicitly when calling make update-make or make update, e.g. make update v0.0.22 or make update latest.

tkrop added a commit that referenced this pull request Jan 9, 2024
Copy link

codacy-production bot commented Jan 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ebcade5) 326 326 100.00%
Head commit (2c212bb) 338 (+12) 338 (+12) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

github-actions bot commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7455417300

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7445242370: 0.0%
Covered Lines: 338
Relevant Lines: 338

💛 - Coveralls

@tkrop tkrop merged commit ba4ff06 into main Jan 9, 2024
8 checks passed
@tkrop tkrop deleted the fix-dirty branch January 9, 2024 01:34
@tkrop tkrop self-assigned this Feb 1, 2024
@tkrop tkrop added the bug Something isn't working label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant