New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect syntax #22

Open

tknerr wants to merge 2 commits into master from expect-syntax

Owner

tknerr commented Sep 14, 2015

Switch to expect syntax which reads more nicely and produces better output in terms of "describing behaviour" rather than technical details.

Before:

       Package "apache2"
         should be installed

       Service "apache2"
         should be enabled
         should be running

       Port "80"
         should be listening

       File "/var/www/sample.html"
         should be file
         should contain "test all the things!"

       Finished in 0.20817 seconds (files took 0.31889 seconds to load)
       6 examples, 0 failures

After:

      sample-app::default       
         installs apache2
         runs starts the apache2 service
         listens on port 80
         renders the sample.html file

       Finished in 0.24001 seconds (files took 0.81071 seconds to load)
       4 examples, 0 failures

tknerr added 2 commits

September 14, 2015 09:52


          switch to rspec expect syntax

1b3f5b8


          fix rubocop warnings

dd984df

Owner Author

tknerr commented Sep 14, 2015

@kimo @damphyr FYI - not sure what's really better, comparing the output before and after...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet