shorten some code in switch

tklengyel · Oct 22, 2021 · 84a2bce · 84a2bce
1 parent 01f0a50
commit 84a2bce
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 20 deletions.
diff --git a/src/libinjector/win/method_helpers.c b/src/libinjector/win/method_helpers.c
@@ -162,3 +162,20 @@ bool is_fun_error(drakvuf_t drakvuf, drakvuf_trap_info_t* info, const char* err)
     }
     return false;
 }
+
+bool open_host_file(injector_t injector, const char* mode)
+{
+    injector->host_file = fopen(injector->binary_path, mode);
+
+    if (!injector->host_file)
+    {
+        PRINT_DEBUG("Failed to open host file\n");
+        injector->rc = INJECTOR_FAILED_WITH_ERROR_CODE;
+        injector->error_code.code = errno;
+        injector->error_code.string = "HOST_FAILED_FOPEN";
+        injector->error_code.valid = true;
+
+        return false;
+    }
+    return true;
+}
diff --git a/src/libinjector/win/method_helpers.h b/src/libinjector/win/method_helpers.h
@@ -108,6 +108,7 @@
 #include "win_utils.h"
 
 bool setup_create_file(drakvuf_t drakvuf, drakvuf_trap_info_t* info);
+bool open_host_file(injector_t injector, const char* mode);
 bool is_fun_error(drakvuf_t drakvuf, drakvuf_trap_info_t* info, const char* err);
 
 #endif
diff --git a/src/libinjector/win/methods/win_read_file.c b/src/libinjector/win/methods/win_read_file.c
@@ -192,18 +192,9 @@ event_response_t handle_readfile_x64(drakvuf_t drakvuf, drakvuf_trap_info_t* inf
                 return cleanup(injector, info);
 
             injector->file_handle = info->regs->rax;
-            injector->host_file = fopen(injector->binary_path, "wb");
-
-            if (!injector->host_file)
-            {
-                PRINT_DEBUG("Failed to open host file\n");
-                injector->rc = INJECTOR_FAILED_WITH_ERROR_CODE;
-                injector->error_code.code = errno;
-                injector->error_code.string = "HOST_FAILED_FOPEN";
-                injector->error_code.valid = true;
 
+            if (!open_host_file(injector, "wb"))
                 return cleanup(injector, info);
-            }
 
             PRINT_DEBUG("Reading file...\n");
 

diff --git a/src/libinjector/win/methods/win_write_file.c b/src/libinjector/win/methods/win_write_file.c
@@ -189,18 +189,10 @@ event_response_t handle_writefile_x64(drakvuf_t drakvuf, drakvuf_trap_info_t* in
                 return cleanup(injector, info);
 
             injector->file_handle = info->regs->rax;
-            injector->host_file = fopen(injector->binary_path, "rb");
-
-            if (!injector->host_file)
-            {
-                PRINT_DEBUG("Failed to open host file\n");
-                injector->rc = INJECTOR_FAILED_WITH_ERROR_CODE;
-                injector->error_code.code = errno;
-                injector->error_code.string = "HOST_FAILED_FOPEN";
-                injector->error_code.valid = true;
 
+            if(!open_host_file(injector, "rb"))
                 return cleanup(injector, info);
-            }
+
         }
         // fall through
         case STEP6: // read chunk from host and write to guest