Encoding is not decoding #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1562f9c seems to conflate the desire to encode request data in utf8 with also decoding server output. In light of tkf#157 and tkf#158, I am removing utf-8 decoding altogether. The impetus to encode to utf-8 in tkf#77, tkf#85, and github/org-trello/#340 suggest nothing about also decoding in utf-8, so I am crossing my fingers I won't rebreak for them. Also, clean up logging. It was impossible to follow with all the capital letters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1562f9c seems to conflate the desire to encode request data in
utf8 with also decoding server output.
In light of #157 and #158, I am removing utf-8 decoding altogether.
The impetus to encode to utf-8 in #77, #85, and
org-trello/org-trello#340 suggest nothing about also decoding in utf-8,
so I am crossing my fingers I won't rebreak for them.
Also, clean up logging. It was impossible to follow with all the
capital letters.