Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix livereload command #64

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

kbuilds
Copy link
Collaborator

@kbuilds kbuilds commented Dec 12, 2022

Hey @tjwalch

I went ahead and merged two PRs which are still sitting out in your main repo:

If you merge the above two, you should see the diff shrink for this MR.

I also fixed an issue with calling the livereload command. It was not picking up the LIVERELOAD_PORT which was set in the settings.

For anyone who wants to use this version in their project, it's hosted here:

https://gitlab.com/obuilds/public/django-livereload-server/-/tags/ob-v3

It can be included in a requirements.txt file like this:

git+https://gitlab.com/obuilds/public/django-livereload-server@ob-v3

@tjwalch
Copy link
Owner

tjwalch commented Dec 15, 2022

@kbuilds As I have little time right now I have invited you to be a collaborator on the project instead.

@kbuilds
Copy link
Collaborator Author

kbuilds commented Jan 2, 2023

Apologies @tjwalch, your invite to collaborate on the project expired. If you send me another one, I will keep a closer eye on my notifications.

My company uses Gitlab pretty exclusively, so I don't make it onto GitHub too often. I added you on LinkedIn in case you want to message me directly.

@tjwalch tjwalch merged commit 9595c28 into tjwalch:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants