update and pin typescript to 2.6.1 #27
Conversation
| @@ -40,7 +40,7 @@ | |||
| "npm-run-all": "^4.1.1", | |||
| "nyc": "^11.0.2", | |||
| "nyc-config-100": "^1.0.1", | |||
| "typescript": "^2.5.3" | |||
| "typescript": "2.6.1" | |||
There was a problem hiding this comment.
I agree to update typescript but I do not see the point to pin it. We are using package-lock.json to lock all our dependencies.
|
Pinning means we get Greenkeeper PR on any new typescript.
…On Sun, Dec 3, 2017, 15:06 Oskar Karlsson ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In package.json
<#27 (comment)>:
> @@ -40,7 +40,7 @@
"npm-run-all": "^4.1.1",
"nyc": "^11.0.2",
"nyc-config-100": "^1.0.1",
- "typescript": "^2.5.3"
+ "typescript": "2.6.1"
I agree to update typescript but I do not see the point to pin it. We are
using package-lock.json to lock all our dependencies.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAmyx2uHL221udDtnEOkvcgLHuA2kwKsks5s8py3gaJpZM4Qp8P1>
.
|
|
@mightyiam, I see but greenkeeper will run our test against every new version of typescript regardless if we have pin it or not. However, if we don't pin it Greenkeep will only create a PR if our test suite fails. If we pin it Greenkeep will create a PR for every new release regardless if the test suite passes or fails, or I'm I wrong? |
|
I close this but please let me know if there is any direct benefit of pinning typescript :) |
|
TypeScript does not follow semver. The recommendation there is to specify a MINOR version. I take it a step further to PATCH to be on the safe side. While Greenkeeper may cause CI to run for any new version (I don't know exactly the behavior), what we desire is that a development environment will have the absolute (PATCH) latest TypeScript. That makes sense to me. For this, we have to pin it. https://github.com/dojo/core/blob/a808fa0e09860aeb180c2359ee81eb1a814491fa/package.json#L56 |
Yeah, this is better. TypeScript do not adhere to semver in the language itself. Every single release, even patch, could break your compilation.