Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 sporadic upload chunk failure to azure storage blob #7

Merged

Conversation

tjgruber
Copy link
Owner

@tjgruber tjgruber commented Jun 4, 2024

Pull Request Summary

This PR addresses the reliability issues encountered during the upload of .intunewin files to Azure Storage blobs by implementing comprehensive retry logic and refining the SAS URI renewal process.

Key Changes:

  1. Retry Logic for Chunk Uploads and Finalization:

    • Added retry mechanism for chunk uploads with a maximum of 5 attempts.
    • Introduced warnings for each retry attempt to enhance visibility into the upload process.
    • Finalization steps now also include retry logic to ensure completion.
  2. SAS URI Renewal Adjustments:

    • Removed the SAS URI renewal attempt from the first retry, opting for a straightforward retry process instead.
    • SAS URI renewal is still attempted if the timer indicates a need for renewal after the initial retries.

Detailed Changes:

  • Invoke-AzureStorageBlobUpload.ps1:
    • Enhanced retry logic for chunk uploads and finalization steps.
  • Invoke-AzureStorageBlobUploadChunk.ps1:
    • Added exception throwing to support retry logic.
  • Invoke-AzureStorageBlobUploadFinalize.ps1:
    • Added exception throwing to support retry logic in the finalization process.
  • Invoke-AzureStorageBlobUploadRenew.ps1:
    • Added a loop to check the status of the SAS URI renewal process.

These improvements are aimed at increasing the robustness and reliability of the Intune Win32 app upload process, reducing the likelihood of failures due to transient issues (throttling) or SAS URI expiration.

Commits:

  • Fix: Add retry logic for Azure Blob uploads
  • Fix: Add SAS URI renewal on first retry with fallback mechanism
  • Fix: Removed renewal from retry logic for initial retries
  • Fix: Add chunk upload retry warning

Impact:

These changes are expected to significantly improve the success rate of .intunewin file uploads to Azure Storage blobs, making the process more resilient to throttling issues.

@tjgruber tjgruber added the bug Something isn't working label Jun 4, 2024
@tjgruber tjgruber self-assigned this Jun 4, 2024
@tjgruber tjgruber linked an issue Jun 4, 2024 that may be closed by this pull request
@tjgruber tjgruber merged commit d59204e into master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic upload chunk failure to Azure Storage blob
1 participant