Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: More Bash improvements and removing deprecations #1016

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

hyperupcall
Copy link
Collaborator

@hyperupcall hyperupcall commented Jan 6, 2023

  • Improve quoting, especially in places where filepaths are used
  • No longer use which, which is deprecated in Debian and has issues - use command -v instead
    • This ends up modifying brew-release.path to match (just to note)
  • No longer use deprecated egrep
  • No longer use deprecated [ -o or ``

@hyperupcall hyperupcall changed the title chore: Move Bash improvements chore: More Bash improvements and removing deprecatiosn Jan 6, 2023
@hyperupcall hyperupcall changed the title chore: More Bash improvements and removing deprecatiosn chore: More Bash improvements and removing deprecations Jan 6, 2023
@spacewander
Copy link
Collaborator

Have you tested if command -v works with a fresh Mac?

@hyperupcall
Copy link
Collaborator Author

hyperupcall commented Jan 6, 2023

The usage is specified in POSIX. And I have used it before, passing Mac CI on my other Bash apps

For your benefit I just tested it with Bash 3.2 on Catalina and it works flawlessly

@spacewander spacewander merged commit d34fa52 into tj:master Jan 10, 2023
@hyperupcall hyperupcall deleted the bash-fixes branch January 14, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants