Replace indexOf with includes #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the relevant if statement to an early return.
shadowspawn
reviewed
May 14, 2020
index.js
Outdated
| } else if ((match = arg.match(/^(--inspect(-brk|-port)?)=([^:]+):(\d+)$/)) !== null) { | ||
| // e.g. --inspect=localhost:1234 | ||
| debugOption = match[1]; | ||
| if (!arg.includes('--inspect')) { |
There was a problem hiding this comment.
This would be better as !arg.startsWith rather than !arg.includes to match the intent of arg.indexOf === 0
There was a problem hiding this comment.
Thank you.
I'm sure you're right
shadowspawn
requested changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
There was some code that was easier to understand using 'includes' than 'indexOf'.
Solution
ChangeLog