Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseOptions rework phase 1 #1138

Merged
merged 8 commits into from
Jan 15, 2020
Next Next commit
Remove openIssues test for #1062, fixed and being tested
shadowspawn committed Jan 4, 2020
commit 898a218630af214f986846cd2ddf988f5f00d73f
15 changes: 0 additions & 15 deletions tests/openIssues.test.js.skip
Original file line number Diff line number Diff line change
@@ -66,19 +66,4 @@ describe('open issues', () => {
done();
});
});

// https://github.com/tj/commander.js/pull/1062
test.skip('#1062 when .action on program with subcommands and no program argument then program action called', () => {
const actionMock = jest.fn();
const program = new commander.Command();
program
.arguments('[file]')
.action(actionMock);
program
.command('subcommand');

program.parse(['node', 'test']);

expect(actionMock).toHaveBeenCalledWith(undefined, program);
});
});