Breaks when using "domain" as an option

[mgartner]

program
  .option('-d, --domain <domain>', 'domain name', 'example.com')
  .parse(process.argv);

events.js:86
    this.domain.enter();
                ^
TypeError: Object example.com has no method 'enter'
    at Command.emit (events.js:86:17)
    at Command.parseOptions (/Users/marcus/delstat/node_modules/commander/index.js:647:14)
    at Command.parse (/Users/marcus/delstat/node_modules/commander/index.js:435:21)
    at Object.<anonymous> (/Users/marcus/delstat/delstat.js:22:4)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)

[SomeKittens]

Can you provide the full example?

[mgartner]

// test.js
'use strict';

var program = require('commander');

program
  .option('-d, --domain <domain>', 'domain name', 'example.com')
  .parse(process.argv);

console.log(program.domain);

$ node test.js -d github.com

events.js:86
    this.domain.enter();
                ^
TypeError: Object example.com has no method 'enter'
    at Command.emit (events.js:86:17)
    at Command.parseOptions (/Users/marcus/commander-test/node_modules/commander/index.js:647:14)
    at Command.parse (/Users/marcus/commander-test/node_modules/commander/index.js:435:21)
    at Object.<anonymous> (/Users/marcus/commander-test/test.js:7:4)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)

[hildjj]

I just ran into this too. Version 2.8.1.

[zhiyelee]

yep. That's a problem, hope can fix it in v3.0, cause it will be a break change.
#404 (comment)

thanks @tonylukasavage for providing the list

[benjamine]

+1

[ilyache]

+1 (still an issue in 2.11.0)

[wolfgang42]

+1, duplicate of #105.

Barring a 3.0 release, maybe trying to use config.option('--domain') should at least raise an error explaining the problem and offering some workaround?

[shadowspawn]

The domain issue in particular is fixed in node 10.

[shadowspawn]

Closing this as covered by #183 and #933

[shadowspawn]

I have opened a Pull Request which allows storing option values separately rather than as command properties (access using .opts()), and passes the options (rather than the command) to the action handler.

See #1102