Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'--domain' option may cause problem #105

Closed
ohsc opened this issue Nov 14, 2012 · 6 comments
Closed

'--domain' option may cause problem #105

ohsc opened this issue Nov 14, 2012 · 6 comments

Comments

@ohsc
Copy link

ohsc commented Nov 14, 2012

Command object inherit from EventEmitter directly. However EventEmitter have a issue that it assume .domain as a Domain instance. And this issue is still opening.

Maybe commander.js could do something to prevent user from using 'domain'.
@tj
Copy link
Owner

tj commented Nov 14, 2012

meh, same issue as --on etc, no way around that unless we change the api

@ohsc
Copy link
Author

ohsc commented Nov 14, 2012

at least make a note in Readme.md

@tj
Copy link
Owner

tj commented Nov 14, 2012

yeah that would be good

@roman-vanesyan
Copy link
Collaborator

roman-vanesyan commented Jun 19, 2017 •
edited
Loading

As a work around we can migrate to another event emitter, rather than standard one.

This was referenced Aug 20, 2017
Closed
Closed
Closed
@wolfgang42 wolfgang42 mentioned this issue Oct 30, 2017
Closed
@shadowspawn shadowspawn mentioned this issue Mar 18, 2019
Closed
@shadowspawn
Copy link
Collaborator

The domain issue in particular is fixed in node 10.

@shadowspawn
Copy link
Collaborator

Closing this as covered by #183 and #933

@phillipj phillipj mentioned this issue Nov 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tj @ohsc @shadowspawn @roman-vanesyan