Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger docs dev action for subdirectories #22

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

eschrock
Copy link
Contributor

Proposed Changes

The github path matching uses go's Path.Match, which doesn't support recursive file handling. Instead, we have to add additional wildcarding for each level. This covers all current levels, but we'll have to be careful if we add more levels. Technically, it should be benign to run the action even if nothing has changed (because we track the hash), so we can also give up the path filtering if it becomes a problem.

@eschrock eschrock requested a review from a team as a code owner September 26, 2019 00:48
@mcred mcred merged commit 3803264 into titan-data:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants