Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed pull on clone unexpectedly leaves partial repo #4

Closed
eschrock opened this issue Sep 20, 2019 · 0 comments · Fixed by #27
Closed

Failed pull on clone unexpectedly leaves partial repo #4

eschrock opened this issue Sep 20, 2019 · 0 comments · Fixed by #27
Assignees
Labels
Type: Bug Something isn't working

Comments

@eschrock
Copy link
Contributor

Expected Behavior

If you clone a repo, but the initial pull fails, you should be able to immediately re-try the clone with whatever error (creds, etc) fixed and have it succeed. We should clean up any partially created repository if later steps fail.

Actual Behavior

The first pull leaves behind the repo, so subsequent attempts fail:

titan clone s3://titan-data-demo/hello-world/postgres hello-world                  ✔  10068  09:52:12 
Exception in thread "main" io.titandata.client.infrastructure.ClientException: repository 'hello-world' already exists

Steps to Reproduce the Problem

Clone from a non-existent S3 bucket, observe that the repo still exists

Version

Titan 0.3.0

@mcred mcred self-assigned this Sep 25, 2019
@mcred mcred added the Type: Bug Something isn't working label Sep 25, 2019
@mcred mcred mentioned this issue Sep 26, 2019
eschrock pushed a commit that referenced this issue Sep 26, 2019
Fixes #4
Fixes #5
Fixes #7
Fixes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants