Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CNNS versioning scheme and improve dependency management #21

Open
wants to merge 3 commits into
base: vl3_latest
Choose a base branch
from
Open

Create CNNS versioning scheme and improve dependency management #21

wants to merge 3 commits into from

Conversation

adodon2go
Copy link
Collaborator

  • Currently we build vl3 & vl3_kiknos images and publish them to Docker Hub:
    • if CIRCLE_USERNAME is tiswanso it will publish under tiswanso user (@tiswanso you will need to add cnns-publish with DOCKER_USER and DOCKER_PASS for your Docker Hub account under your CircleCI project)
    • otherwise it will publish under cnns user
  • In case you do a git tag (on official or on your forked repo), vl3 & vl3_kiknos images will be published with the git tag (Ex: cnns/ucnf-kiknos-vppagent:vl3-v0.1.2 or cnns/vl3_ucnf-vl3-nse:vl3-v0.1.2)
  • if CIRCLE_USERNAME is tiswanso images will be published with tag ${CIRCLE_BRANCH} (Ex: vl_latest, vl3_stable,etc)
  • if CIRCLE_USERNAME is not tiswanso, images will be published with ${CIRCLE_SHA1} tag
  • Updated CircleCI config to pass tests

@adodon2go adodon2go changed the base branch from master to vl3_latest June 27, 2020 18:12
@tiswanso
Copy link
Owner

IMO, we don't want to remove the e2e job. It's actually failing for a few reasons but the primary one is that the config lib is returning failures and the nse control binary is exiting.

If I run the nse-binary manually (via in an ssh circleci session):

root@vl3-nse-ucnf-747b5588d4-m9t2r:~# /bin/cnf-vppagent
INFO[0000] Waiting for liveness probe: tcp:localhost:9113
INFO[0000] Resetting vppagent...
INFO[0000] Finished resetting vppagent...
ERRO[0000] error: yaml: unmarshal errors:
  line 5: field cnns not found in type config.Endpoint
  line 9: field vl3 not found in type config.Endpoint
FATA[0000] Error processing [/etc/universal-cnf/config.yaml]: yaml: unmarshal errors:
  line 5: field cnns not found in type config.Endpoint
  line 9: field vl3 not found in type config.Endpoint

I can morph this PR into what I'm thinking for labels as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants