-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tone down Maven plugin output #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change, what's the output?
The output you attached seems have some duplicate. Not sure this patch keep one output or filter out all.
The duplicate run is kind expected. At least it was this way in the original plugin. The session is injected at the very beginning, and then after projects are read to allow injecting into projects. |
I pushed some changes. The output is the following:
|
Please give me some time before releasing, the above change made me realise the extension was working on Maven master, but not on 4.0.0-beta-4, so I'd like to provide a fix before next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Let me know if this is good to merge.
You can change PR to draft if you find any other blocker.
And I'd appreciate it if you can link the related Maven PR you mentioned above.
Feel free to merge and release. I cannot find a way to make it work on Maven 4.0.0-beta-4, so it'll require coming beta-5 anyway... |
Thank you! |
The current output for a project that uses this Maven extension is the following (when running with Maven 3.x):
This is really verbose (and duplicate), so I'd suggest to just move all the log to debug in Maven.