Restore Maven 4 extension #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
force-pushed
the
maven-4-extension
branch
from
f43a63d
to
ea8408c
Compare
gnodet
force-pushed
the
maven-4-extension
branch
from
ea8408c
to
351c423
Compare
tisonkun
approved these changes
Sep 27, 2024
|
Thanks for your contribution! |
|
Released 0.4.0 for public ref. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying the current main branch, I restored the Maven 4 specific extension.
The reason is that Maven 4 provides a specific extension point for this very usage, and the execution time is way faster than having to go through all projects to manually interpolate all properties.
In a project such as Apache Camel (roughly 500 subprojects), the time spend when running Maven 4 with the previous extension is almost 4 seconds at startup, and just nothin with this PR.
@tisonkun