Skip to content

Commit

Permalink
pythongh-95913: make the new internal classes pdb.ModuleTarget/Script…
Browse files Browse the repository at this point in the history
…Target private (pythonGH-96053)
  • Loading branch information
iritkatriel authored and tiran committed Aug 19, 2022
1 parent a9eba71 commit eae213f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Lib/pdb.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def __repr__(self):
return self


class ScriptTarget(str):
class _ScriptTarget(str):
def __new__(cls, val):
# Mutate self to be the "real path".
res = super().__new__(cls, os.path.realpath(val))
Expand Down Expand Up @@ -167,7 +167,7 @@ def code(self):
return f"exec(compile({fp.read()!r}, {self!r}, 'exec'))"


class ModuleTarget(str):
class _ModuleTarget(str):
def check(self):
try:
self._details
Expand Down Expand Up @@ -1625,7 +1625,7 @@ def lookupmodule(self, filename):
return fullname
return None

def _run(self, target: Union[ModuleTarget, ScriptTarget]):
def _run(self, target: Union[_ModuleTarget, _ScriptTarget]):
# When bdb sets tracing, a number of call and line events happen
# BEFORE debugger even reaches user's code (and the exact sequence of
# events depends on python version). Take special measures to
Expand Down Expand Up @@ -1789,7 +1789,7 @@ def main():
commands = [optarg for opt, optarg in opts if opt in ['-c', '--command']]

module_indicated = any(opt in ['-m'] for opt, optarg in opts)
cls = ModuleTarget if module_indicated else ScriptTarget
cls = _ModuleTarget if module_indicated else _ScriptTarget
target = cls(args[0])

target.check()
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_pyclbr.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def test_others(self):
cm(
'pdb',
# pyclbr does not handle elegantly `typing` or properties
ignore=('Union', 'ModuleTarget', 'ScriptTarget'),
ignore=('Union', '_ModuleTarget', '_ScriptTarget'),
)
cm('pydoc', ignore=('input', 'output',)) # properties

Expand Down

0 comments on commit eae213f

Please sign in to comment.