#33012: Small refactor

tiobe · Oct 23, 2023 · bff2eb4 · bff2eb4
1 parent 731eba5
commit bff2eb4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -107,7 +107,7 @@ const octokitOptions = {
         retryAfter: 5
     }
 };
-exports.octokit = new (core_2.Octokit.plugin(plugin_paginate_rest_1.paginateRest, plugin_rest_endpoint_methods_1.restEndpointMethods, plugin_retry_1.retry).defaults(octokitOptions))();
+exports.octokit = new (core_2.Octokit.plugin(plugin_paginate_rest_1.paginateRest, plugin_rest_endpoint_methods_1.restEndpointMethods, plugin_retry_1.retry))(octokitOptions);
 exports.baseUrl = (0, api_helper_1.getTicsWebBaseUrlFromUrl)(exports.ticsConfig.ticsConfiguration);
 exports.viewerUrl = exports.ticsConfig.viewerUrl ? exports.ticsConfig.viewerUrl.replace(/\/+$/, '') : exports.baseUrl;
 

diff --git a/src/configuration.ts b/src/configuration.ts
@@ -107,6 +107,6 @@ const octokitOptions: OctokitOptions = {
   }
 };
 
-export const octokit = new (Octokit.plugin(paginateRest, restEndpointMethods, retry).defaults(octokitOptions))();
+export const octokit = new (Octokit.plugin(paginateRest, restEndpointMethods, retry))(octokitOptions);
 export const baseUrl = getTicsWebBaseUrlFromUrl(ticsConfig.ticsConfiguration);
 export const viewerUrl = ticsConfig.viewerUrl ? ticsConfig.viewerUrl.replace(/\/+$/, '') : baseUrl;
diff --git a/test/integration/octokit.test.ts b/test/integration/octokit.test.ts
@@ -59,7 +59,7 @@ describe('@octokit/action (using https_proxy)', () => {
   test('Should return basic REST request, but not through the proxy', async () => {
     // setting no_proxy
     const originalNoProxy = process.env['no_proxy'];
-    process.env['no_proxy'] = 'api.github.com:443';
+    process.env['no_proxy'] = 'api.github.com';
 
     const branch = await octokit.rest.repos.getBranch({
       owner: 'tiobe',