#34408: Unsetting environment variables a different way

tiobe · Jun 11, 2024 · 17df77b · 17df77b
1 parent b8dfd10
commit 17df77b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -1308,14 +1308,12 @@ class TicsConfiguration {
     setVariables() {
         // variable set to replace the loading bar with synchronising... in the install script
         (0, environment_1.setVariable)('TICSCI', '1');
-        logger_1.logger.info(process.env.TICSIDE || "TICSIDE not found");
         if (this.mode === Mode.CLIENT || this.mode === Mode.DIAGNOSTIC) {
             (0, environment_1.setVariable)('TICSIDE', 'GITHUB');
         }
         else if (process.env.TICSIDE) {
             (0, environment_1.unsetVariable)('TICSIDE');
         }
-        logger_1.logger.info(process.env.TICSIDE || "TICSIDE not found");
         // set ticsAuthToken
         if (this.ticsAuthToken) {
             (0, environment_1.setVariable)('TICSAUTHTOKEN', this.ticsAuthToken);
@@ -1859,7 +1857,7 @@ function setVariable(key, value) {
 }
 exports.setVariable = setVariable;
 function unsetVariable(key) {
-    delete process.env[key];
+    process.env[key] = '';
 }
 exports.unsetVariable = unsetVariable;
 

diff --git a/src/configuration/tics.ts b/src/configuration/tics.ts
@@ -158,13 +158,11 @@ export class TicsConfiguration {
     // variable set to replace the loading bar with synchronising... in the install script
     setVariable('TICSCI', '1');
 
-    logger.info(process.env.TICSIDE || "TICSIDE not found")
     if (this.mode === Mode.CLIENT || this.mode === Mode.DIAGNOSTIC) {
       setVariable('TICSIDE', 'GITHUB');
     } else if (process.env.TICSIDE) {
       unsetVariable('TICSIDE')
     }
-    logger.info(process.env.TICSIDE || "TICSIDE not found")
 
     // set ticsAuthToken
     if (this.ticsAuthToken) {

diff --git a/src/helper/environment.ts b/src/helper/environment.ts
@@ -3,5 +3,5 @@ export function setVariable(key: string, value: string): void {
 }
 
 export function unsetVariable(key: string): void {
-  delete process.env[key];
+  process.env[key] = '';
 }