machine/atmega328pb: refactor to actually support this chip #4016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes support for
atmega328pb
chip, code for which does not actually compile now.The reason is
pb
variant has two ofI2C
andSPI
interfaces compared with otheratmega
chips that only have one of each. This results in respective registers naming mismatch and compilation failure.Also,
PWM
support forpb
variant was implemented only rudimentary, this PR fixes that too.Adding
atmega328pb.json
target file (see in this PR) and running a simple compilation results in multiple errors this PR fixes.