compiler,runtime: fix multiple definitions of a single function #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails on Go 1.11 only, because the change was introduced in Go 1.12. @deadprogram maybe we should drop support for Go 1.11? One reason for keeping it would be that the next Debian stable release will ship with Go 1.11 so supporting Go 1.11 would ease the installation for people using that. Alternatives would be to allow multiple definitions and just pick the first (gross, hard to maintain in the future) or to check the version of the used Go standard library (more work). Any preferences? |
|
I hate to say it, but checking the version of the Go standard library sounds like the way. The Debian thing is reason enough. |
strings.IndexByte was implemented in the runtime up to Go 1.11. It is implemented using a direct call to internal/bytealg.IndexByte since Go 1.12. Make sure we remain compatible with both.
aykevl
force-pushed
the
fix-multiple-definitions
branch
from
af6870c to
7217610
Compare
|
This is hopefully fixed now. |
|
It fixes it for me. Now merging, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strings.IndexByteused to be implemented in the runtime. Now it is implemented using a direct call tointernal/bytealg.IndexByte. Fixes #351.The real problem is of course golang/go#31330.