epd2in66b: Waveshare 2.66inch E-Paper Display Module (B) for Raspberry Pi Pico #673
Conversation
|
In an optimal scenario, we would add an In the meantime, using the |
waveshare-epd/epd2in66b/dev.go
Outdated
| width int16 | ||
| height int16 |
There was a problem hiding this comment.
Do these need to be in the struct since they are not being changed. Constants could be used directly, but I would rename them to something more unique (eg displayWidth) to avoid unintentional shadowing.
waveshare-epd/epd2in66b/dev.go
Outdated
| func set(buf []byte, bytePos, bitPos int, v bool) { | ||
| if v { | ||
| buf[bytePos] |= 0x1 << bitPos | ||
| } else { | ||
| buf[bytePos] &^= 0x1 << bitPos | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe split this function into two: set and clear so you don't have to have bool argument and if. It should be a bit faster that way.
There was a problem hiding this comment.
Ah, good point. Done.
| @@ -19,7 +19,7 @@ rwildcard=$(foreach d,$(wildcard $1*),$(call rwildcard,$d/,$2) $(filter $(subst | |||
| # Recursively find all *_test.go files from cwd & reduce to unique dir names | |||
| HAS_TESTS = $(sort $(dir $(call rwildcard,,*_test.go))) | |||
| # Exclude anything we explicitly don't want to test for whatever reason | |||
| EXCLUDE_TESTS = image | |||
| EXCLUDE_TESTS = image waveshare-epd/epd2in66b | |||
There was a problem hiding this comment.
Alternatively I remove the tests for now, though I found them quite useful for myself.
trichner
force-pushed
the
tr/epd2in66b
branch
2 times, most recently
from
f5d785e
to
738cd08
Compare
|
Looks like it is missing the example? https://github.com/tinygo-org/drivers/actions/runs/8860923503/job/24332227160?pr=673#step:8:308 |
Too much copy paste, should be fixed. Sorry about that. |
|
Why is this driver specific to the pico? It looks like a regular driver to me that should work on any chip? |
The driver 'should' already work with any other chip. The pins & SPI is all configurable. If this looks too specific, I can also remove the pico HAT specific defaults. What would you prefer? Either works for me. On a side note: I did not manage to figure out whether this is a specific waveshare driver chip or something more generic. |
It would be better to make them more generic. To make life easier for devs, you could also add a file protected by build tag, with the specific values for the board you are using. That way the "default" case for your board "just works". @trichner what do you think? |
Sounds good! I gave it a try with build flags, was this what you had in mind? |
| // in case you have a Pico module, you can directly use | ||
| // dev, err := epd2in66b.NewPicoModule() |
There was a problem hiding this comment.
I've kept the example for the generic setup with this hint for the specific pico use case.
| @@ -0,0 +1,34 @@ | |||
| //go:build pico | |||
There was a problem hiding this comment.
obviously only works for picos ;)
|
@deadprogram let me know if anything else is missing or needs change. |
|
Alright, all cleaned up! |
|
Anything left? |
|
Ping? :) |
|
Thanks for adding this @trichner now squash/merging. |
A simple driver for the Waveshare 2.66in EPD for the Pico. Heavily inspired by the official python implementation and its magic timing.
See also: https://www.waveshare.com/Pico-ePaper-2.66-B.htm
Using
machinepackage currently breaks the build.How should I go about removing the
machinepackage from the unit tests?Example looks like this:
