qmi8658c: Add support for the QMI8658C sensor #467
Conversation
qmi8658c/qmi8658c.go
Outdated
| } | ||
| } | ||
|
|
||
| // Check if the usar has defined a desired configuration, if not uses the |
There was a problem hiding this comment.
Fixed the typo, thanks for noticing.
qmi8658c/qmi8658c.go
Outdated
| } | ||
|
|
||
| // Read the temperature from the sensor, the values returned are in Celsius. | ||
| func (d *Device) ReadTemperature() (t float32) { |
There was a problem hiding this comment.
Please, follow the signature ReadTemperature() (int32, error) { as other drivers do. It should return millidegrees:
https://github.com/tinygo-org/drivers/blob/release/bme280/bme280.go#L116
As a rule of thumb, avoid float when possible.
There was a problem hiding this comment.
Changed the signature as proposed and updated the example file.
My main language is Python and I'm new to Go and TinyGo, so I have to ask, this would be for memory optimization? Since float32 would use a lot more memory than int32?
There was a problem hiding this comment.
I don't know the details, but yes, the boards targeted don't have much memory and don't play well with floats in general.
|
Apparently they are 90 devices, if I can count correctly. All changes were made, hope it's alright now. Thank you very much for the review. |
|
Thanks for your contribution, it's a very well written driver. |
* Add support for the QMI8658C sensor * qmi8656c: update ReadTemperature signature * Update README devices count
* Add support for the QMI8658C sensor * qmi8656c: update ReadTemperature signature * Update README devices count
Add initial support for the QMI8658C Accelerometer and Gyroscope sensor by QST Solution.
This sensor is used in the WaveShare RP2040 Round LCD 1.28in development board.
Add an example based on the aforementioned development board.
Add smoke test to
makefileand updateREADME.md