-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XPT2046 Touch driver #350
XPT2046 Touch driver #350
Conversation
Thank you for your contribution. |
I would like you to implement the following interface. Lines 4 to 6 in 90a13a6
|
I've added an example and migrated to the ReadTouchPoint interface. I removed the internal scaling to display size to be consistent with the fourwire implementation however I currently return 12 bit values. Should I scale them to 16 bit to match fourwire? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
For the most part I think it is very nice.
Please add it to README.md.
Also, please add smoketest to the Makefile.
I've added a default value of 10 for precision if the user sets it to 0 and I now scale the values to 16 bits I'd like to say thank you for guiding me through the requirements for contributions to this project. This is my first commit to tinygo and its been very enjoyable so far :) |
It seems that there are few cases where the config struct contains pin information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm a little concerned because I think tz
is probably 24-bit-range.
However, this is probably not a problem for z.
Thank you for your contribution. |
No description provided.