Sensor interface PR proof of concept #335
Conversation
|
|
||
| func (d *Device) Update(which drivers.Measurement) (err error) { | ||
| // Temperature is needed for presssure calculation. | ||
| if which|drivers.Temperature|drivers.Pressure == 0 { |
There was a problem hiding this comment.
Shall it not return some sort of error when measurement requested is not temperature or pressure?
There was a problem hiding this comment.
The reason behind it not being an error is to allow for grouping of Sensors.
allSensors := []Sensor{imu, bmp, tempSens}
updateAll := func (w Measurement) {
for _, sens := range allSensors {
sens.Update(w) // illustrative, please handle your errors
}
}This way you can have precise requests of what sensor measurements you want to update. This is especially useful if the characteristic time of a sensor is very slow compared to other sensors in the group, i.e Temperature sensor vs. voltage sensor.
There was a problem hiding this comment.
It might be worth thinking about this a bit more. Maybe it's worth having a io.EOF sentinel like error for the case you mention Yurii, for example: drivers.ErrNoMeasurement.
| } | ||
|
|
||
| // Channel returns an ADC measurement for a specific channel. Must call Update Beforehand | ||
| func (d *BufferedDev) Channel(ch int) uint16 { |
There was a problem hiding this comment.
Why this name? Shall be "Voltage"?
There was a problem hiding this comment.
So maybe this name should be Get, the reason it is not Voltage is because it does not represent the voltage, merely the bits read by the ADC. I have added the Voltage method separate as a conversion of Channel.
|
|
||
| // UNTESTED | ||
| func (d *BufferedDev) Update(which drivers.Measurement) error { | ||
| if which|drivers.Voltage == 0 { |
There was a problem hiding this comment.
Right now it only reads voltage, can read more things?
If only voltage ever, why have which drivers.Measurement at all?
soypat
force-pushed
the
dev-sensor-impl
branch
from
3bb7ba6 to
de642c6
Compare
soypat
force-pushed
the
dev-sensor-impl
branch
from
de642c6 to
a5b5fbf
Compare
Proof of concept for #321. WIP